search

fasiha / ebisu.js

JavaScript port of Ebisu, the public-domain library for Bayesian quiz scheduling.
The Unlicense
44 stars 7 forks source link

Return for `modelToPercentileDecay` not multiplied to `t0` #3

Closed jasonsparc closed 4 years ago

jasonsparc commented 4 years ago

https://github.com/fasiha/ebisu.js/blob/b280e18955ef958ad4ceb4890226c6eee0b59460/dist/ebisu.js#L117

For modelToPercentileDecay, it seems that at this line, the return value should have been multiplied by t0, just like in the python implementation.

fasiha commented 4 years ago

Thank you so much for catching this! I am dreadfully ashamed that this bug made it through reviews and tests 😭.