codecov[bot]
commented
3 years ago Codecov Report
Merging #375 (2745a14) into master (1d61db3) will decrease coverage by
0.05%. The diff coverage is75.67%.
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 91.50% 91.44% -0.06%
==========================================
Files 192 192
Lines 7744 7761 +17
Branches 732 734 +2
==========================================
+ Hits 7086 7097 +11
- Misses 518 523 +5
- Partials 140 141 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/fastoad/gui/optimization_viewer.py | 72.68% <ø> (ø) |
|
| src/fastoad/gui/variable_viewer.py | 80.57% <ø> (ø) |
|
| src/fastoad/openmdao/variables.py | 89.96% <73.52%> (-1.48%) |
:arrow_down: |
| src/fastoad/cmd/api.py | 94.14% <100.00%> (ø) |
|
| src/fastoad/io/xml/variable_io_base.py | 93.13% <100.00%> (ø) |
|
| src/fastoad/openmdao/_utils.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1d61db3...2745a14. Read the comment docs.
This PR makes FAST-OAD compatible with OpenMDAO 3.10.
The point is that OpenMDAO now consistently uses "val" and no more "value", wherever it applies. Though OpenMDAO team aimed at backward compatibility, FAST-OAD code is broken by this change and then, usage of "val" is now adopted in FAST-OAD.
Doing so, it now requires at least OpenMDAO 3.10.
For convenience, our Variable class now accepts both keywords and has both properties "val" and "value". Same applies for "desc" and "description".