search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
53 stars 26 forks source link

Mission computation: engine setting in cruise #397

Closed christophe-david closed 2 years ago

christophe-david commented 2 years ago

This PR fixes #396. The bug was forcing engine setting to climb if an altitude target was set for the cruise segment.

Additional checks have been put in related tests.

It also proposes release of version 1.1.2: https://github.com/fast-aircraft-design/FAST-OAD/releases/untagged-02fe8a16462bc2c95738

codecov[bot] commented 2 years ago

Codecov Report

Merging #397 (2d2662a) into master (722308a) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   90.38%   90.38%   -0.01%     
==========================================
  Files         200      200              
  Lines        8174     8172       -2     
  Branches      849      849              
==========================================
- Hits         7388     7386       -2     
  Misses        635      635              
  Partials      151      151
Impacted Files Coverage Δ
...oad/models/performances/mission/segments/cruise.py 96.73% <ø> (ø)
...stoad/models/performances/mission/segments/base.py 90.44% <100.00%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 722308a...2d2662a. Read the comment docs.