search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Model separation #414

Closed christophe-david closed 2 years ago

christophe-david commented 2 years ago

This PR moved CS25-related models to package [fast-oad-cs25](https://pypi.org/project/fast-oad-cs25/).

To preserve backward compatibility, a dependency to this package has been added in pyproject.toml. Integration tests that use CS25 models have been kept for now.

Also, for sake of keeping previous behavior when generating configuration file, api.generate_configuration_file() has been modified so that distribution_name can be omitted if only one plugin provides conf files or the one file name that is asked. Therefore, if only one configuration file is provided among all available plugins, there is no need to specify its name nor the plugin that provides it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #414 (c7ffacc) into master (405f2cd) will decrease coverage by 2.74%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   92.10%   89.35%   -2.75%     
==========================================
  Files         206       73     -133     
  Lines        8512     4378    -4134     
  Branches      929      700     -229     
==========================================
- Hits         7840     3912    -3928     
+ Misses        498      337     -161     
+ Partials      174      129      -45
Impacted Files Coverage Δ
...tebooks/01_custom_modules/modules/displacements.py 0.00% <ø> (ø)
...ks/01_custom_modules/modules/section_properties.py 0.00% <ø> (ø)
...ad/notebooks/01_custom_modules/modules/stresses.py 0.00% <ø> (ø)
...toad/notebooks/01_custom_modules/modules/weight.py 0.00% <ø> (ø)
src/fastoad/cmd/api.py 91.72% <100.00%> (+0.71%) :arrow_up:
src/fastoad/model_base/propulsion.py 69.81% <0.00%> (-28.31%) :arrow_down:
src/fastoad/constants.py 76.92% <0.00%> (-12.83%) :arrow_down:
src/fastoad/module_management/_bundle_loader.py 96.81% <0.00%> (+2.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 405f2cd...c7ffacc. Read the comment docs.