codecov[bot]
commented
2 years ago Codecov Report
Merging #420 (89aeed8) into master (aefda7f) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 73 73
Lines 4380 4380
Branches 700 700
=======================================
Hits 3913 3913
Misses 338 338
Partials 129 129 Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 786c3f8...89aeed8. Read the comment docs.
Now PyPI FAST-OAD package is the "assembly" of FAST-OAD-core and FAST-OAD-CS25.
For release 1.3.0, we released a version 1.3.0 of FAST-OAD, that contains only core code, but is declared dependent of FAST-OAD-CS25, so that the latter is installed along with FAST-OAD. We also created a FAST-OAD-core, that is identical to FAST-OAD, but is not declared dependent of FAST-OAD-CS25.
In the mean time, FAST-OAD-CS25 0.1.0 is declared dependent of FAST-OAD.
As a result, after an installation of FAST-OAD-core, installing FAST-OAD-CS25 will trigger the installation of FAST-OAD. Therefore, FAST-OAD and FAST-OAD-core would be installed simultaneously, although they are duplicata. Bad idea, especially when one of them is uninstalled. Consequences are difficult to predict.
The current solution is to create a 1.3.0post0 release of FAST-OAD that is an empty shell which only triggers the installation of FAST-OAD-core and FAST-OAD-CS25.
As a (non-urgent) complement, FAST-OAD-CS25 will have to be dependent of FAST-OAD-core instead of FAST-OAD.