Closed florentLutz closed 1 year ago
Just writing down an idea about the problem we should define: why not a payload/range computation ?
I guess the optimization of fuel consumption could still take place, but with less convolution. And we could also consider a different payload (max payload), constraint the MTOW, and find the maximum achievable range.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Round 2:
I responded to all the comments that were made and closed everyone that I agreed with. Those that are left open mght need further discussing.
For the separation between the two sets of notebooks: I made it so the notebook 5 explains the same thing as the custom module notebook, Consequently all references to the custom module notebook were deleted and a README was added at the root of the notebook folders to explains the differences between the two.
Paragraphs were added to prepare some future works, manely on how hard it would be to add a new model in pure_python and partials derivatives.
Added two proper paragraphs on the N2 diagram, the use of the set_val function and a widget for component selection.
I also tried to improve readability by removing some parts of phrases and, adding, commas, as, much, as, possible :stuck_out_tongue_winking_eye:
Made the requested changes on grammar, typos and phrasing Tweaked the accuracy and number of significant digits so that MDA results work Changed the number of significant digits so that we can see that Scipy and OpenMDAO gives better results Still an issued with the wing mass formula (to discuss)
In this pull request a new serie of tutorials has been added to help the user get familiar with the coding in the FAST-OAD framework. It consists in taking a simple problem and coding it with various tools ranging from a pure Python implementation to coding and using FAST-OAD. It is separated in 5 notebooks.
A couple of issue to discuss :