search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Hot fix release 1.3.2 : compatibility with OpenMDAO 3.17 #428

Closed christophe-david closed 2 years ago

christophe-david commented 2 years ago

Resolves #427.

OpenMDAO 3.17 modifies the signature of om.Problem.set_val(), which caused FAST-OAD 1.3.1 to crash at problem initialization.

Also, the unit test for FASTOADProblem.write_outputs() needed a small fix.

codecov[bot] commented 2 years ago

Codecov Report

Merging #428 (70a303d) into master (d9f6b82) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 70a303d differs from pull request most recent head 7302d05. Consider uploading reports for the commit 7302d05 to get more accurate results

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          73       73           
  Lines        4381     4381           
  Branches      701      701           
=======================================
  Hits         3917     3917           
  Misses        336      336           
  Partials      128      128
Impacted Files Coverage Δ
src/fastoad/openmdao/problem.py 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 987d2fe...7302d05. Read the comment docs.