Run system can fail when using shape_by_conn and copy shape in some inputs

[florentLutz]

Describe the bug There can be an issue with the run_system function when giving in argument a group which contains components that have inputs which copy the shape of a different input

To Reproduce The following code provides with a simple example of how to make the error happen : test_copy_shape.zip

Expected behavior The expected behaviour would be that there are no None shape which would prevent OpenMDAO from crashing.

Error message

FAILED        [100%]
test_copy_shape.py:132 (test_shape_by_conn_fast_oad_run_system)
def test_shape_by_conn_fast_oad_run_system():

        ivc = om.IndepVarComp()
        ivc.add_output("data:foo", val=np.array([1.0, 2.0, 3.0]))
        ivc.add_output("data:bar", val=np.array([4.0, 5.0, 6.0]))
        ivc.add_output("baz", val=np.array([0.1, 0.2, 0.3]))

>       p = run_system(WingLoads(), ivc)

test_copy_shape.py:140: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
..\..\Anaconda3\envs\FAST_OAD_bug_replication\lib\site-packages\fastoad\_utils\testing.py:40: in run_system
    problem.setup(mode=setup_mode)
..\..\Anaconda3\envs\FAST_OAD_bug_replication\lib\site-packages\openmdao\core\problem.py:971: in setup
    model._setup(model_comm, mode, self._metadata)
..\..\Anaconda3\envs\FAST_OAD_bug_replication\lib\site-packages\openmdao\core\system.py:856: in _setup
    self._setup_var_sizes()
..\..\Anaconda3\envs\FAST_OAD_bug_replication\lib\site-packages\openmdao\core\group.py:1366: in _setup_var_sizes
    subsys._setup_var_sizes()
..\..\Anaconda3\envs\FAST_OAD_bug_replication\lib\site-packages\openmdao\core\group.py:1366: in _setup_var_sizes
    subsys._setup_var_sizes()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <test_copy_shape.StructuralLoads object at 0x0000013C45983B50>

    def _setup_var_sizes(self):
        """
        Compute the arrays of variable sizes for all variables/procs on this system.
        """
        iproc = self.comm.rank
        abs2idx = self._var_allprocs_abs2idx = {}

        for io in ('input', 'output'):
            sizes = self._var_sizes[io] = np.zeros((self.comm.size, len(self._var_rel_names[io])),
                                                   dtype=INT_DTYPE)

            for i, (name, metadata) in enumerate(self._var_allprocs_abs2meta[io].items()):
>               sizes[iproc, i] = metadata['size']
E               TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

..\..\Anaconda3\envs\FAST_OAD_bug_replication\lib\site-packages\openmdao\core\component.py:298: TypeError

Environment

• Operating System: Windows 10 Entrprise
• Python environment: Anaconda Python 3.9.11
• Packages: aenum==3.1.8 anyio==3.5.0 argon2-cffi==21.3.0 argon2-cffi-bindings==21.2.0 asttokens==2.0.5 atomicwrites==1.4.0 attrs==21.4.0 Babel==2.9.1 backcall==0.2.0 beautifulsoup4==4.10.0 black==22.3.0 bleach==4.1.0 certifi==2021.10.8 cffi==1.15.0 charset-normalizer==2.0.12 click==8.1.2 colorama==0.4.4 debugpy==1.6.0 decorator==5.1.1 defusedxml==0.7.1 Deprecated==1.2.13 ensure==1.0.2 entrypoints==0.4 executing==0.8.3 fast-oad-core==1.3.1 fastjsonschema==2.15.3 idna==3.3 importlib-metadata==4.11.3 iniconfig==1.1.1 iPOPO==1.0.1 ipykernel==6.12.1 ipysheet==0.5.0 ipython==8.2.0 ipython-genutils==0.2.0 ipywidgets==7.7.0 jedi==0.18.1 Jinja2==3.1.1 json5==0.9.6 jsonrpclib-pelix==0.4.3.2 jsonschema==4.4.0 jupyter-client==7.2.1 jupyter-core==4.9.2 jupyter-server==1.16.0 jupyterlab==3.3.2 jupyterlab-pygments==0.1.2 jupyterlab-server==2.12.0 jupyterlab-widgets==1.1.0 lxml==4.8.0 MarkupSafe==2.1.1 matplotlib-inline==0.1.3 mistune==0.8.4 mypy-extensions==0.4.3 nbclassic==0.3.7 nbclient==0.5.13 nbconvert==6.4.5 nbformat==5.3.0 nest-asyncio==1.5.5 networkx==2.7.1 notebook==6.4.10 notebook-shim==0.1.0 numpy==1.22.3 openmdao==3.16.0 openmdao-extensions==1.0.2 packaging==21.3 pandas==1.4.2 pandocfilters==1.5.0 parso==0.8.3 pathspec==0.9.0 pickleshare==0.7.5 pip==21.2.4 platformdirs==2.5.1 plotly==5.6.0 pluggy==1.0.0 prometheus-client==0.13.1 prompt-toolkit==3.0.29 psutil==5.9.0 pure-eval==0.2.2 py==1.11.0 pycparser==2.21 pyDOE2==1.3.0 Pygments==2.11.2 pyparsing==3.0.7 pyrsistent==0.18.1 pytest==7.1.1 python-dateutil==2.8.2 pytz==2022.1 pywin32==303 pywinpty==2.0.5 pyzmq==22.3.0 requests==2.27.1 ruamel.yaml==0.17.21 ruamel.yaml.clib==0.2.6 scipy==1.8.0 Send2Trash==1.8.0 setuptools==58.0.4 six==1.16.0 sniffio==1.2.0 soupsieve==2.3.1 stack-data==0.2.0 stdatm==0.2.0 tabulate==0.8.9 tenacity==8.0.1 terminado==0.13.3 testpath==0.6.0 tomli==2.0.1 tomlkit==0.10.1 tornado==6.1 traitlets==5.1.1 typing_extensions==4.1.1 urllib3==1.26.9 wcwidth==0.2.5 webencodings==0.5.1 websocket-client==1.3.2 wheel==0.37.1 widgetsnbextension==3.6.0 wincertstore==0.2 wop==1.21.3 wrapt==1.14.0 xdsmjs==1.0.1 zipp==3.8.0

Additional context Weirdly enough replacing baz with data:baz or removing the data in front of foo and bar will solve the issue on this test case

[florentLutz]

The problem comes from the fact that in some components of the code variable foocopies the shape of bar, but not in another one, even if foo is not used. This, however, only happens when using the run_system so it is bound to unit_tests. A simple workaround is to declare foo as an input with a proper copy shape but not use it.