search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Added nbstripout to dependencies and pre-commit #433

Closed ScottDelbecq closed 2 years ago

ScottDelbecq commented 2 years ago

This small PR adds nbstripout to dependencies and pre-commit hooks. This way notebook outputs are deleted when notebooks are committed. I tested the pre-commit and it seems to work fine. Once approved and merged I will do the same modifications for the CS_25 repository which contains more notebooks.

codecov[bot] commented 2 years ago

Codecov Report

Merging #433 (473d58f) into master (34a4542) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          73       73           
  Lines        4381     4381           
  Branches      701      701           
=======================================
  Hits         3917     3917           
  Misses        336      336           
  Partials      128      128

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34a4542...473d58f. Read the comment docs.

ScottDelbecq commented 2 years ago

I agree but I was willing to have it in the dev dependencies to use it whenever I want without waiting for a commit :)