Closed christophe-david closed 2 years ago
Merging #435 (93424f5) into master (f11d685) will decrease coverage by
0.00%
. The diff coverage is87.50%
.
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 89.36% 89.35% -0.01%
==========================================
Files 73 73
Lines 4381 4398 +17
Branches 701 707 +6
==========================================
+ Hits 3915 3930 +15
Misses 338 338
- Partials 128 130 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/fastoad/io/variable_io.py | 91.78% <80.95%> (-1.21%) |
:arrow_down: |
src/fastoad/openmdao/variables/variable_list.py | 93.75% <100.00%> (+0.03%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f11d685...93424f5. Read the comment docs.
This PR aims at easing a bit the usage of DataFile class:
save_as()
methodBTW, I changed a bit the GitHub workflows to take advantage of the cache management of the
setup-python
action, that works for Poetry (bye byeactions/cache
). I used this branch as a sandbox to test it.Finally, since CodeClimate was nagging me with a "two many nested control flows" in the dreaded
VariableList.from_problem()
method (just because I slightly modified it to fix issue 421), I decided to comply by simply using a guard clause.