search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
53 stars 26 forks source link

Issue 436 - configuration file connections with indepvarcomp #437

Closed ScottDelbecq closed 2 years ago

ScottDelbecq commented 2 years ago

This PR resolves #436. The issue was that IndepVarComp connections were ignored when analyzing connections for sorting inputs and outputs. Thus, the variables to which they were connected were still considered as inputs and therefore added to the generated input file.

codecov[bot] commented 2 years ago

Codecov Report

Merging #437 (bd0e06d) into master (f11d685) will increase coverage by 0.07%. The diff coverage is 100.00%.

:exclamation: Current head bd0e06d differs from pull request most recent head e9441a0. Consider uploading reports for the commit e9441a0 to get more accurate results

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   89.36%   89.44%   +0.07%     
==========================================
  Files          73       73              
  Lines        4381     4385       +4     
  Branches      701      703       +2     
==========================================
+ Hits         3915     3922       +7     
+ Misses        338      337       -1     
+ Partials      128      126       -2
Impacted Files Coverage Δ
src/fastoad/openmdao/variables/variable_list.py 95.26% <100.00%> (+1.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f11d685...e9441a0. Read the comment docs.