search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Fix for crash in multiprocessing environment #442

Closed christophe-david closed 2 years ago

christophe-david commented 2 years ago

This PR fixes #441.

It ensures that the OpenMDAO MPI communicators are removed from Problem instances before doing a deepcopy operation.

For good measure, our GitHub test workflow now runs with MPI capabilities installed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #442 (526be98) into master (6fe418d) will increase coverage by 0.03%. The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   89.43%   89.47%   +0.03%     
==========================================
  Files          73       73              
  Lines        4401     4416      +15     
  Branches      709      709              
==========================================
+ Hits         3936     3951      +15     
  Misses        337      337              
  Partials      128      128
Impacted Files Coverage Δ
src/fastoad/openmdao/problem.py 93.83% <94.44%> (+0.08%) :arrow_up:
src/fastoad/openmdao/_utils.py 100.00% <100.00%> (ø)
src/fastoad/openmdao/variables/variable_list.py 95.28% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fe418d...526be98. Read the comment docs.