search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
53 stars 26 forks source link

Deactivated automatic reports. #449

Closed christophe-david closed 2 years ago

christophe-david commented 2 years ago

Solves #448. Quick fix to avoid uncontrolled generation of reports folder with OpenMDAO 3.17+.

Solution is to deactivate entirely this feature, unless environment variable OPENMDAO_REPORTS is set. I suggest we see later if we add a control for it in the configuration file.

No test is implemented for this modification, since I prefer to keep our Poetry environment with the old OpenMDAO 3.10 (yet I tested it "manually", of course)). At least, watchman tests will ensure the change does not cause any crash.

codecov[bot] commented 2 years ago

Codecov Report

Merging #449 (de568a7) into master (b9742b0) will decrease coverage by 0.03%. The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   89.51%   89.47%   -0.04%     
==========================================
  Files          73       73              
  Lines        4433     4436       +3     
  Branches      713      714       +1     
==========================================
+ Hits         3968     3969       +1     
- Misses        337      338       +1     
- Partials      128      129       +1
Impacted Files Coverage Δ
src/fastoad/openmdao/problem.py 92.81% <77.27%> (-1.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9742b0...de568a7. Read the comment docs.