search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Now allowing more than 5 datasets in mass breakdown bar plot #451

Closed christophe-david closed 2 years ago

christophe-david commented 2 years ago

Fixes #450.

The number of datasets in mass breakdown bar plot was limited to 5 due to an incorrect indexing in the list plotly.colors.DEFAULT_PLOTLY_COLORS (which contains 10 items).

Besides, colors in mass breakdown plot were inconsistent with colors in other plots (geometry, polar). The color list for mass breakdown bar plot is now close to the one used in other plots.

codecov[bot] commented 2 years ago

Codecov Report

Merging #451 (6be69ae) into master (710af2d) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          73       73           
  Lines        4436     4436           
  Branches      714      714           
=======================================
  Hits         3969     3969           
  Misses        338      338           
  Partials      129      129
Impacted Files Coverage Δ
src/fastoad/gui/analysis_and_plots.py 98.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 710af2d...6be69ae. Read the comment docs.