Closed esnguyenvan closed 1 year ago
Merging #473 (be7c82d) into master (2b2a2b0) will increase coverage by
0.05%
. The diff coverage is91.02%
.:exclamation: Current head be7c82d differs from pull request most recent head bc3a953. Consider uploading reports for the commit bc3a953 to get more accurate results
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 83.42% 83.47% +0.05%
==========================================
Files 122 123 +1
Lines 5520 5490 -30
Branches 837 836 -1
==========================================
- Hits 4605 4583 -22
+ Misses 766 751 -15
- Partials 149 156 +7
Impacted Files | Coverage Δ | |
---|---|---|
...performances/mission/openmdao/mission_component.py | 88.03% <0.00%> (ø) |
|
src/fastoad/models/performances/mission/polar.py | 87.50% <82.92%> (-12.50%) |
:arrow_down: |
...rformances/mission/segments/ground_speed_change.py | 87.23% <87.23%> (ø) |
|
...n_definition/mission_builder/structure_builders.py | 93.75% <87.50%> (-0.37%) |
:arrow_down: |
...d/models/performances/mission/segments/rotation.py | 93.10% <93.10%> (ø) |
|
...ls/performances/mission/segments/end_of_takeoff.py | 96.22% <96.22%> (ø) |
|
...stoad/models/performances/mission/ground_effect.py | 96.29% <96.29%> (ø) |
|
src/fastoad/model_base/flight_point.py | 93.18% <100.00%> (+0.24%) |
:arrow_up: |
...sion_definition/mission_builder/mission_builder.py | 89.39% <100.00%> (+1.55%) |
:arrow_up: |
.../performances/mission/mission_definition/schema.py | 97.14% <100.00%> (-0.23%) |
:arrow_down: |
... and 16 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Replaced by #481, #484, #485, #487, #488 and #490.
Hello,
This is a contribution to include take off simulation in the performance module. The newly created segments allow the simulation of ground acceleration and deceleration (for start and stop test), rotation and lift-off up to the safety altitude. The use of a polar with ground effect is included (although optional and not very significant for SMR). Tests files together with the specific mission definition file are provided and documentation is included. What is left to decide after an initial review: -Decide to include or not the take-off manoeuvre in the default mission file, -Decide to provide or not a module to compute an adequate Vr as this speed must be chosen by the applicant (an input as of today, if it is too low, it stops the mission).
Thanks for your review