fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
51 stars 25 forks source link

Problems with Numpy 1.24.0 #476

Closed florentLutz closed 1 year ago

florentLutz commented 1 year ago

Describe the bug The solution for compatibility between OpenMDAO and Numpy 1.24.0 (https://github.com/OpenMDAO/OpenMDAO/issues/2737) has not been integrated in a release yet creating issues on new installs of FAST-OAD and its plugins.

Fix A quick fix is to downgrade the version of numpy to anything below 1.24.0

christophe-david commented 1 year ago

What is the concerned OpenMDAO version in your tests? I realize OpenMDAO 3.23 got released on the 10th of January, and is advertised as getting along with numpy 1.24.

If your test is with OpenMDAO 3.23, we will have to look deeper into that problem...

florentLutz commented 1 year ago

I managed to replicate the bug on the Binder and sure enough, the version of OpenMDAO was 3.21.0. I tried upgrading to 3.23.0 and the issue disapeared (didn't check further). However, when upgrading to the 3.23.0 I got the following message:

pip install openmdao==3.23.0
Collecting openmdao==3.23.0
  Downloading openmdao-3.23.0.tar.gz (5.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.3/5.3 MB 34.8 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... done
Requirement already satisfied: networkx>=2.0 in /srv/conda/envs/notebook/lib/python3.8/site-packages (from openmdao==3.23.0) (2.8.8)
Requirement already satisfied: numpy in /srv/conda/envs/notebook/lib/python3.8/site-packages (from openmdao==3.23.0) (1.23.5)
Requirement already satisfied: scipy in /srv/conda/envs/notebook/lib/python3.8/site-packages (from openmdao==3.23.0) (1.9.3)
Requirement already satisfied: requests in /srv/conda/envs/notebook/lib/python3.8/site-packages (from openmdao==3.23.0) (2.28.1)
Requirement already satisfied: packaging in /srv/conda/envs/notebook/lib/python3.8/site-packages (from openmdao==3.23.0) (21.3)
Requirement already satisfied: pyparsing!=3.0.5,>=2.0.2 in /srv/conda/envs/notebook/lib/python3.8/site-packages (from packaging->openmdao==3.23.0) (3.0.9)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in /srv/conda/envs/notebook/lib/python3.8/site-packages (from requests->openmdao==3.23.0) (1.26.11)
Requirement already satisfied: charset-normalizer<3,>=2 in /srv/conda/envs/notebook/lib/python3.8/site-packages (from requests->openmdao==3.23.0) (2.1.1)
Requirement already satisfied: idna<4,>=2.5 in /srv/conda/envs/notebook/lib/python3.8/site-packages (from requests->openmdao==3.23.0) (3.4)
Requirement already satisfied: certifi>=2017.4.17 in /srv/conda/envs/notebook/lib/python3.8/site-packages (from requests->openmdao==3.23.0) (2022.9.24)
Building wheels for collected packages: openmdao
  Building wheel for openmdao (setup.py) ... done
  Created wheel for openmdao: filename=openmdao-3.23.0-py3-none-any.whl size=5806391 sha256=0517bc7dce1ac1484616d29197b987f516f2e5fcdd9bd988dba378a091071adf
  Stored in directory: /home/jovyan/.cache/pip/wheels/35/7d/84/03d1663a4f2694741021ba0a18aee54e254bbc89cf35df0ebd
Successfully built openmdao
Installing collected packages: openmdao
  Attempting uninstall: openmdao
    Found existing installation: openmdao 3.21.0
    Uninstalling openmdao-3.21.0:
      Successfully uninstalled openmdao-3.21.0
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
fast-oad-core 1.4.1 requires openmdao<=3.21,>=3.10, but you have openmdao 3.23.0 which is incompatible.
Successfully installed openmdao-3.23.0

Which might explains why it didn't install the latest version of OpenMDAO

christophe-david commented 1 year ago

Looks like there is no more problem when last versions of numpy and openMDAO are installed.