fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
51 stars 25 forks source link

Added only takeoff segments and polar. #481

Closed esnguyenvan closed 1 year ago

esnguyenvan commented 1 year ago

This is a separate pull request to include only dedicated takeoff segments and polar modifier. The changes to mission builder will be added separately.

codecov[bot] commented 1 year ago

Codecov Report

Merging #481 (fb246ad) into master (6aa9de5) will increase coverage by 0.27%. The diff coverage is 92.18%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   83.42%   83.70%   +0.27%     
==========================================
  Files         122      126       +4     
  Lines        5520     5706     +186     
  Branches      837      853      +16     
==========================================
+ Hits         4605     4776     +171     
- Misses        766      776      +10     
- Partials      149      154       +5     
Impacted Files Coverage Δ
...rformances/mission/segments/ground_speed_change.py 70.00% <70.00%> (ø)
src/fastoad/models/performances/mission/polar.py 94.11% <88.88%> (-5.89%) :arrow_down:
...d/models/performances/mission/segments/rotation.py 90.90% <90.90%> (ø)
...stoad/models/performances/mission/segments/base.py 90.67% <94.87%> (+0.62%) :arrow_up:
...ls/performances/mission/segments/end_of_takeoff.py 96.22% <96.22%> (ø)
src/fastoad/model_base/flight_point.py 93.18% <100.00%> (+0.24%) :arrow_up:
...toad/models/performances/mission/polar_modifier.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

esnguyenvan commented 1 year ago

Hello, Thanks for the comments, I tried to address everything and proposed some additional changes in the last commit. Please let me know if I forgot something or if new changes have to be corrected

esnguyenvan commented 1 year ago

Now it should be fixed with rebase from master