Closed christophe-david closed 1 year ago
Merging #487 (2714904) into master (16c4c95) will decrease coverage by
0.02%
. The diff coverage is84.61%
.
@@ Coverage Diff @@
## master #487 +/- ##
==========================================
- Coverage 84.27% 84.25% -0.02%
==========================================
Files 128 128
Lines 5946 5971 +25
Branches 874 880 +6
==========================================
+ Hits 5011 5031 +20
- Misses 781 784 +3
- Partials 154 156 +2
Impacted Files | Coverage Δ | |
---|---|---|
...on/mission_definition/mission_builder/constants.py | 100.00% <ø> (ø) |
|
src/fastoad/models/performances/mission/polar.py | 94.11% <0.00%> (ø) |
|
...rformances/mission/segments/ground_speed_change.py | 77.77% <ø> (-3.18%) |
:arrow_down: |
src/fastoad/models/performances/mission/base.py | 90.74% <60.00%> (-3.26%) |
:arrow_down: |
...n_definition/mission_builder/structure_builders.py | 91.35% <78.94%> (-2.76%) |
:arrow_down: |
...stoad/models/performances/mission/segments/base.py | 91.98% <83.33%> (+0.09%) |
:arrow_up: |
src/fastoad/model_base/flight_point.py | 93.18% <100.00%> (ø) |
|
...sion_definition/mission_builder/mission_builder.py | 88.75% <100.00%> (+0.54%) |
:arrow_up: |
...toad/models/performances/mission/polar_modifier.py | 100.00% <100.00%> (ø) |
|
...rmances/mission/segments/takeoff/end_of_takeoff.py | 96.22% <100.00%> (-0.21%) |
:arrow_down: |
... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This PR allow to use takeoff segments in mission file.
The main changes are:
Among minor changes, there are:
TakeOffSequence
has been completed with needed parameters (rotation_rate
androtation_alpha_limit
).alpha
parameter inGroundSpeedChangeSegment
, that was supposed to provide the angle of attack at starting point. This information should come from the provided starting point. Therefore,alpha
value inFlightPoint
is now 0.0 by default, and the default behavior inAbstractTimeStepFlightSegment
is that the next computed flight point has same alpha as the previous one.Note: the strong dependency of the
TakeOffSequence
parameters to the ones of aggregated segments could make future evolutions more complicated. This will be addressed in next PR.