search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Fix datafile #494

Closed christophe-david closed 1 year ago

christophe-david commented 1 year ago

This PR fixes #421.

It also enhances a bit the dreadful VariableList.from_problem() method by putting it outside of VariableList class and cutting it into more meaningful pieces (hopefully).

codecov[bot] commented 1 year ago

Codecov Report

Merging #494 (f5271cf) into master (c0f245f) will increase coverage by 0.03%. The diff coverage is 95.06%.

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   84.37%   84.41%   +0.03%     
==========================================
  Files         130      131       +1     
  Lines        6005     6018      +13     
  Branches      884      883       -1     
==========================================
+ Hits         5067     5080      +13     
  Misses        783      783              
  Partials      155      155
Impacted Files Coverage Δ
src/fastoad/openmdao/variables/variable_list.py 95.00% <85.71%> (-0.33%) :arrow_down:
src/fastoad/openmdao/variables/_util.py 97.01% <97.01%> (ø)