Fix for climb segment going far too high when asked for optimal altitude in some cases

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design

GNU General Public License v3.0

47 stars 25 forks source link

Fix for climb segment going far too high when asked for optimal altitude in some cases #497

Closed esnguyenvan closed 1 year ago

esnguyenvan commented 1 year ago

Added test to recreate a bug in the climb segment causing the aircraft to climb indefinitely when it gets just a little higher than MAXIMUM_FLIGHT_LEVEL when trying to reach OPTIMAL_FLIGHT_LEVEL and implemented the fix (lowered tolerance of root_scalar function looking for the moment at which target is reached).