fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Refactoring of Sellar-related tests #512

Closed christophe-david closed 3 months ago

christophe-david commented 3 months ago

This PR concerns only the unit tests in FAST-OAD code.

The Sellar problem is used in several unit tests.

The Sellar problem was entirely redefined at each location it was used. Indeed, there are always some particularities, linked to the tested feature, and it's good that each test has its dedicated "inputs".

But the history of development makes that the Sellar problem of one tests is often the (modified) copy from a previously developed test. And as a matter of fact, some features of the original test may have been kept in the new one, even without being needed.

Then it looks better to have a common ground for tested Sellar problems, while keeping the possibility to keep local specificities, which is done in this PR.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.60%. Comparing base (885edfd) to head (39079fa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #512 +/- ## ========================================== + Coverage 84.30% 84.60% +0.30% ========================================== Files 132 137 +5 Lines 6117 6250 +133 Branches 903 906 +3 ========================================== + Hits 5157 5288 +131 - Misses 806 808 +2 Partials 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.