search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
51 stars 25 forks source link

Base class for cycle groups #516

Closed christophe-david closed 6 months ago

christophe-david commented 6 months ago

This PR adds a base class for groups that contain a NLGS solver.

It is a way to standardize the control of inner solvers through options, making it easy to control all of them at once using model_options in configuration file.

This PR also allows having a dict as option value, which is the way solver options will be set from the configuration file.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (6595a97) to head (b4d16c5).

Files Patch % Lines
src/fastoad/openmdao/base_model_classes.py 33.33% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master-v1.7.x #516 +/- ## ================================================= - Coverage 84.60% 84.51% -0.10% ================================================= Files 137 138 +1 Lines 6250 6263 +13 Branches 906 907 +1 ================================================= + Hits 5288 5293 +5 - Misses 808 816 +8 Partials 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.