search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
51 stars 25 forks source link

Fix cycle groups #528

Closed christophe-david closed 3 months ago

christophe-david commented 3 months ago

This PR enhances the CycleGroup class, that was preventing custom settings of solvers for derived classes.

Doc preview : https://fast-oad.readthedocs.io/en/fix-cycle-groups/documentation/custom_modules/add_modules.html#the-cyclegroup-class

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (e9111e8) to head (1634445). Report is 6 commits behind head on master.

Files Patch % Lines
src/fastoad/model_base/openmdao/group.py 97.72% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 84.48% 84.66% +0.18% ========================================== Files 138 138 Lines 6310 6340 +30 Branches 907 911 +4 ========================================== + Hits 5331 5368 +37 + Misses 823 815 -8 - Partials 156 157 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.