search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Fixed issue 534 #535

Closed florentLutz closed 2 weeks ago

florentLutz commented 2 weeks ago

Made it so that the altitude and ground distance are taken by default when displaying the mission viewer if it is at all possible. Also added corresponding tests to check that it indeed works. This PR closes #534

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.15%. Comparing base (d300e7d) to head (7e1f528). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #535 +/- ## ========================================== + Coverage 84.73% 85.15% +0.41% ========================================== Files 138 138 Lines 6343 6353 +10 Branches 912 912 ========================================== + Hits 5375 5410 +35 + Misses 811 785 -26 - Partials 157 158 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mokyoslurp commented 2 weeks ago

The test flight_points.csv files may be a little old since some of the keys of the flight_points.csv generated with newer FAST-OAD versions come with the unit ("altitude [m]", "mass [kg]", etc), so the mission viewer still plots altitude against isa_offset (using default keys 1 and 2) with new flight_points.csv.

florentLutz commented 2 weeks ago

Thank you for being vigilant @Mokyoslurp. Updated the column name we seek to match the format used in the FlightPoint class which is used as a base to write the output csv. Also added some freshly generated .csv file in the test.