search

fast-aircraft-design / FAST-OAD

FAST-OAD: An open source framework for rapid Overall Aircraft Design
GNU General Public License v3.0
47 stars 25 forks source link

Adding grouped legend for each aircraft configuration (fix issue #544) #545

Closed aeomath closed 1 week ago

aeomath commented 1 week ago

This PR should close issue #544

When using subplots in the mass_breakdown_bar_plot , it was impossible to isolate one aircraft from another and only one plot was masked.

To resolve this , we create a grouped legend for each aircraft configuration ( same methods as the one to have the same color for each aircraft)

aeomath commented 1 week ago

Thanks a lot for your help and your time !

I was indeed not aware of the black auto-format tool as well as the pre-commit. I will be more careful next time !

christophe-david commented 1 week ago

And be sure having auto-format activated in your IDE will make your life easier. To be noted: we currently use Black, but we will soon switch to Ruff, that has the advantage of doing formatting and linting, and of doing them in a flash.

Also, this PR made me aware that only a part of our test workflows are triggered by external pull requests. And among the missing tests, there is the check of formatting. Then it is a valuable experience for us also :)