fastaddons / GroupSpeedDial

This repository is for tracking bugs and documentation only
Other
54 stars 5 forks source link

Ctrl+number doesn't work properly after v25.0 #324

Closed morrogenduath closed 1 month ago

morrogenduath commented 2 months ago

Describe the bug I can only activate ctrl+2, ctrl+3 or ctrl+4 with the speed dial after updating to version 25.0

Steps To Reproduce Choosing any other combination (ctrl+8, ctrl+12, etc.) doesn't activate the appropriate link from the speed dial.

Device info:

Juraj-Masiar commented 2 months ago

Thanks for reporting, I'll investigate it now.

bathindahelper commented 2 months ago

For me too. When I press a KB shortcut, it (FF) tries to flash (for a micro second) the same tab number of the browser, as the shortcut key I pressed. E.g. If I pressed Ctrl+4 then 4th tab in the FF Browser will flash for a tiny second but nothing will happen. And if I press higher number (e.g. Ctrl+9 or 0), then nothing visibly happens.

Full details with the screen shots can be seen here.

On the side: how can I resize the 'Group Speed Dial' options to appear on right side, in a floating window? Currently they open in full tab.

Juraj-Masiar commented 2 months ago

As a workaround, you can downgrade to the previous version: https://addons.mozilla.org/addon/groupspeeddial/versions/ But make sure to export your dials to a file from Options page / Import backup tab / Export all. Just to be sure so that you have a full backup. You will also need to disable auto-update for my addon in the "about:addons" page. Ideally only temporarily until I fix it.

I still don't have it fixed but I'll to fix it today. I had some urgent server issues I had to attend to yesterday. Also, I woke up a bit sick today so my productivity is down :( I'm sorry for the issues!

morrogenduath commented 2 months ago

Please take care of yourself first. A broken Juraj is no good to us :-D

bathindahelper commented 2 months ago

@morrogenduath are you saying something to me pls? Have I said something wrong?

Juraj-Masiar commented 2 months ago

@bathindahelper I think all messages here are addressed to me :).

I've just finished fixing this issue, so it will work again in the next release. Let me just fix one more issue and I'll submit it for review.

EDIT: Fixed version 25.2 was just submitted for review to the Firefox store, hopefully it will take only a day to review and approve it.

UPDATE: Still awaiting review, please be patient :) image

Juraj-Masiar commented 1 month ago

Good news! New version has just been approved! I can't believe it took a whole leek... maybe due to public holiday in the middle of week. Anyway, if you haven't been updated yet, you can check for updates now from about:addons page: https://github.com/fastaddons/GroupSpeedDial/wiki/How-to-update-to-latest-version#firefox

Usually it takes about 24h to get auto-updated. Also, if you disabled auto-update for my addon, don't forget to enable it again.