search

fastai / course-v3

The 3rd edition of course.fast.ai
https://course.fast.ai/
Apache License 2.0
4.91k stars 3.57k forks source link

Update Video Viewer #469

Closed charlescatta closed 3 years ago

charlescatta commented 4 years ago

Quite a large PR, sorry about that!

I updated the dependencies to latest and rewrote a good amount of the app to achieve the three panel layout cleanly.

Here is a video preview of the update: https://youtu.be/4xg7EAr2RzY

Currently only tested on Chrome 80 on Windows 10, Safari 13.0.4 on MacOS and Safari on iOS 13.3.1

Fixes #464

Caveats

  1. If you ever have an eslint error, this is caused by the create-react-app package upgrade, simply delete your node_modules and run the following: 
    npm cache clean
npm install
jph00 commented 3 years ago

@charlescatta thanks so much for this! I apologize it took so long to merge - COVID-19 and writing a book got in the way of things...

One request - the little buttons to toggle the side panels visibility are pretty hard to see now. Any change you could move them back to the middle of the panel edges?