search

fastai / course22

The fast.ai course notebooks
https://course.fast.ai
2.39k stars 934 forks source link

Updated the DuckDuckGo import and getting images function #108

Open MMurtazanb opened 8 months ago

MMurtazanb commented 8 months ago

This is a minor change and one can search for a solution and get it, but the premise that anyone can actually open the notebook, run it and see instant results is so cool. With this change in the ddg api there is an error which needs to be corrected before you can complete the run.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

anrikus commented 7 months ago

The current PR has the outputs included. I would suggest revising the PR with the outputs cleared.

MMurtazanb commented 7 months ago

@anrikus - Updated the file and the clean version and resubmitted the PR. Please help to check and merge if all good. Thanks

tonybustamante commented 1 week ago

I'm relatively new to code review with regards to jupyter notebooks, but it looks like there is also quite a bit of noise included in the pull request that pertains the the jupyter notebook environment.