Update 06_foundations.ipynb

fastai / course22p2

course.fast.ai 2022 part 2

https://course.fast.ai/Lessons/part2.html

Apache License 2.0

467 stars 252 forks source link

Update 06_foundations.ipynb #13

Closed faisito closed 1 year ago

faisito commented 1 year ago

after_calc method needs both calc object and epoch value

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jph00 commented 1 year ago

It appears to be working correctly at the moment? Can you please say more about the purpose of this PR?

faisito commented 1 year ago

My bad! It IS working I had a typo later and corrected the wrong thing to make it work the current code is good

FYI My typo was creating calculator as calculator = SlowCalculator(ModifyingCallback) instead of calculator = SlowCalculator(ModifyingCallback()) So had to change the good logic in the SlowCalculator class in order to get my code to work