search

fastai / course22p2

course.fast.ai 2022 part 2
https://course.fast.ai/Lessons/part2.html
Apache License 2.0
467 stars 252 forks source link

Small Fixes #14

Closed tcapelle closed 1 year ago

tcapelle commented 1 year ago

This PR fixes the missing args for show_images and adds the scheduler to the learner object

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jph00 commented 1 year ago

Thanks! Can you make this a more minimal diff without all the changes to images and other outputs, and remove the stacktrace that appears in one notebook?

tcapelle commented 1 year ago

Ok, I did nbdev_clean --clear_all

jph00 commented 1 year ago

Unfortunately that deleted all the outputs!

tcapelle commented 1 year ago

Ok, re run everything, but lot's of warning on M1Pro

tcapelle commented 1 year ago

I will close this then... don't know how to resolve the conflicts

jph00 commented 1 year ago

I'll fix show_images directly.