fastai / course22p2

course.fast.ai 2022 part 2
https://course.fast.ai/Lessons/part2.html
Apache License 2.0
467 stars 252 forks source link

Two definitions of conv imported in resnet.py #24

Open mnslarcher opened 1 year ago

mnslarcher commented 1 year ago

In resnet.py there are (more than) two import *:

from .conv import *
from .init import *

Both contain a conv def. It took me a moment to figure out where the one that was actually used was (given the name I would have said in conv), maybe it would be helpful a refactoring or to avoid the "import "? I think this is a classic case where import can lead to unexpected behavior, what do you think?