nbdev_build_lib + remove kwargs in load_image + update contributing

fastai / fastai2

Temporary home for fastai v2 while it's being developed

https://dev.fast.ai

Apache License 2.0

645 stars 234 forks source link

Closed KushajveerSingh closed 4 years ago

KushajveerSingh commented 4 years ago

Ran nbdev_build_lib.
Removed **kwargs in load_image.
Updated Contributing in README. When trying to clone fastai2 on local machine there is an issue you do not have have access rights to download fastai-docs. This is solved by forking fastai-docs also on github. Added this in the README.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

github-actions[bot] commented 4 years ago

👋 @KushajveerSingh! We detected notebooks that are not stripped or that are out of sync with the library in this PR.

You need to run nbdev_install_git_hooks before submitting a pull request! For more information, see the CONTRIBUTING guide.

You can see the logs of the tests that triggered this message in run 200590512.

github-actions[bot] commented 4 years ago

👋 @KushajveerSingh! We detected notebooks that are not stripped or that are out of sync with the library in this PR.

You need to run nbdev_install_git_hooks before submitting a pull request! For more information, see the CONTRIBUTING guide.

You can see the logs of the tests that triggered this message in run 200596550.