search

fastai / fastai_dev

fast.ai early development experiments
Apache License 2.0
641 stars 351 forks source link

added QHAdam optimizer and fixed tests #295

Closed morganmcg1 closed 4 years ago

morganmcg1 commented 5 years ago

Adding the QHAdam optimizer which has shown promise on the fastai forums when combined with Lookahead

review-notebook-app[bot] commented 5 years ago

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

morganmcg1 commented 5 years ago

Not sure why the checks failed, I followed the steps here : https://forums.fast.ai/t/submitting-pr-to-fastai-v2/54146

And I ran notebook2script as below

~/fastai_dev/dev$ python notebook2script.py --fname 12_optimizer.ipynb

Yet I still get this error

!!! Diff between nbs and scripts
!!!Remember to run notebook2script.py or script2notebook.py
##[error]Bash exited with code '1'.
sgugger commented 5 years ago

Thanks for the PR! I have one minor issue to fix before merging if you don't mind. Will look at why the diff produces something if the problem persists.

morganmcg1 commented 5 years ago

Comment addressed :)

sgugger commented 4 years ago

Thanks!