search

fastai / fastai_dev

fast.ai early development experiments
Apache License 2.0
641 stars 351 forks source link

Remove Package.resolved and add a typealias #316

Closed texasmichelle closed 4 years ago

texasmichelle commented 4 years ago

This week, the S4TF team encountered several failures building toolchains:

  1. Outdated Package.resolved in swift/FastaiNotebook_11_imagenette.
  2. A regression in ParameterlessLayer caused by a change in type inference behavior in apple/swift#32578.

This PR includes two workarounds that unblock toolchain builds:

  1. Remove Package.resolved (swift-apis/1036). Since this file is regenerated on build, it's often not necessary to include in source control.
  2. Add a typealias to instances conforming to ParameterlessLayer, which was effective in swift-apis and swift-models (see tensorflow/swift-apis#1037).

I'm happy to create an additional PR to remove the other Package.resolved files in this repo and add to .gitignore, if desired.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

saeta commented 4 years ago

Note: the CI failures appear to be unrelated (and present in a variety of past merged PRs), so I'm going to go ahead and merge this in. Thanks @texasmichelle !