search

fastai / fastbook

The fastai book, published as Jupyter Notebooks
Other
21.41k stars 8.3k forks source link

Update 01_intro.ipynb - IMDb reviews sentiment analysis prediction output change #633

Closed ShubhamThakkar closed 2 months ago

ShubhamThakkar commented 6 months ago

I think output in the markdown cell does not match the description below it.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

djsamseng commented 4 months ago

LGTM! This undoes this incorrect change https://github.com/fastai/fastbook/commit/bb0dadf1ec360b957a6ba512da952aef6b69091e#diff-2797ef6b1a7e774fb61038401a8b5d7a9da91f43da3744f3ed6dc18796126074R2265 (Expand the diff for 01_intro.ipynb and it should jump to line 2265)

ShubhamThakkar commented 2 months ago

@djsamseng, thanks for reviewing it. Will you be merging it or should we ping someone else?

djsamseng commented 2 months ago

@djsamseng, thanks for reviewing it. Will you be merging it or should we ping someone else?

Yeah ping one of the owners as I don't have merge privileges

ShubhamThakkar commented 2 months ago

@jph00 , can you please review it.