search

fastai / fastcore

Python supercharged for the fastai library
http://fastcore.fast.ai
Apache License 2.0
954 stars 274 forks source link

Why does this package require `pip`? #540

Closed rafrafek closed 4 months ago

rafrafek commented 8 months ago

Hi!

I can see this package and also fastai/ghapi both require pip. I have a big monorepo project with a lot of dependencies and these two are the only ones that require pip. Requiring pip means its version is now being locked in my monorepo's Poetry-created lock file. It also means every time there is a pip update I have to manually bump it in my lock file because I don't bump everything automatically. I use poetry lock --no-update in contrast to poetry lock. I'm not sure if locking pip is a standard approach. I may be wrong though. Is there a reason for requiring pip?

Thanks!

mohitmishra786 commented 5 months ago

As much i am aware of, this library can be installed using mamba @rafrafek

rafrafek commented 5 months ago

Can pip be removed from this line ? Are pip and packaging specified here needed for the end user?

https://github.com/fastai/fastcore/blob/1cb38a0d8d97091cd3365e669e39db64be40aaa2/setup.py#L29

jph00 commented 4 months ago

Maybe you're right -- I'll remove it.

rafrafek commented 2 months ago

Thank you, @jph00 !

Do you think it can also be removed from ghapi?

https://github.com/fastai/ghapi/issues/172