do not list bytes - Githubissues

fastai / fastcore

Python supercharged for the fastai library

http://fastcore.fast.ai

Apache License 2.0

954 stars 274 forks source link

do not list bytes #584

Closed ababino closed 1 month ago

ababino commented 1 month ago

Currenlty, if you do listify(b'hi') you get [104, 105]. Wouldn't it be better to match how listify behaves with strings? If so, this PR changes that. In this implementation, listify(b'hi') returns [b'hi']

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jph00 commented 1 month ago

Makes perfect sense!