fastai / fastdoc

Create publication-quality books from Jupyter notebooks
https://fastai.github.io/fastdoc/
Apache License 2.0
232 stars 30 forks source link

Asciidoc conversion does not respect heading levels #11

Closed lewtun closed 3 years ago

lewtun commented 3 years ago

Hi @jph00,

First of all, thank you for open-sourcing this tool - it's super useful for a textbook I'm currently working on!

I'm running into a small problem with the heading levels. Please see the details below.

Description of the problem

I have a notebook with different heading levels (simple gist here) all of which appear with the same == level in the resulting .asciidoc file.

Is this by design or does one need to add a special flag to the markdown cells?

Steps to reproduce

  1. Download the simple notebook from this gist
  2. Run the following commands
    cd path/to/fastdoc_sections_test.ipynb
    mkdir images
    fastdoc_convert_all --path ./ --dest_path convert_book

Expected output

An fastdoc_sections_test.asciidoc file with the following content

== Heading level 1

=== Heading level 2

==== Heading level 3

Actual output

== Heading level 1

== Heading level 2

== Heading level 3
lewtun commented 3 years ago

Sorry, just saw this is a duplicate of #10. Closing the issue

jph00 commented 3 years ago

Well spotted :D