search

fastai / fastdoc

Create publication-quality books from Jupyter notebooks
https://fastai.github.io/fastdoc/
Apache License 2.0
231 stars 30 forks source link

Correct footnote example in _test.ipynb? #12

Open lewtun opened 3 years ago

lewtun commented 3 years ago

Hi @jph00,

In the test notebook, the footnote example is shown as

A footnote[this is a footnote]

however my understanding from the AsciiDoc docs is that a colon is required to render the footnote, i.e.

A footnote:[this is a footnote]

If you agree, I'd be happy to fix the test notebook!

jph00 commented 3 years ago

Have you tried both in asciidoctor to see if either or both render correctly?

lewtun commented 3 years ago

Hi Jeremy, yes I tried both and have opened a PR with the fix :)