search

fastai / fastdoc

Create publication-quality books from Jupyter notebooks
https://fastai.github.io/fastdoc/
Apache License 2.0
231 stars 30 forks source link

Fix footnotes #14

Open lewtun opened 3 years ago

lewtun commented 3 years ago

This PR fixes the example to generate footnotes in test/_test.ipynb. Previously we had

A footnote[this is a footnote]

which generated via asciidoctor the following output:

Screen Shot 2021-01-19 at 3 00 34 pm

With the fix, we now have:

Screen Shot 2021-01-19 at 3 34 15 pm

which is consistent with the asciidoc docs.

I also took the liberty of adding a note to the README about ignored files during the conversion.

Closes #12

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB