search

fastai / fastdoc

Create publication-quality books from Jupyter notebooks
https://fastai.github.io/fastdoc/
Apache License 2.0
232 stars 30 forks source link

Hyperlinks break when included in note, tip, and warning elements #17

Closed lewtun closed 3 years ago

lewtun commented 3 years ago

Asciidoc markup expects hyperlinks to be formatted as follows:

Visit the http://oreilly.com[O'Reilly website]

fastdoc doesn't perform the appropriate conversion from Markdown to Asciidoc for the note, tip, and warning elements. For example, consider adding a hyperlink to the following Note element in a Jupyter notebook:

> Note: This is a note with some [link](https://github.com/fastai)

Expected Asciidoc

[NOTE]
====
This is a note with some https://github.com/fastai[link]
====

Actual Asciidoc

[NOTE]
====
This is a note with some [link](https://github.com/fastai)
====