search

fastai / fastdoc

Create publication-quality books from Jupyter notebooks
https://fastai.github.io/fastdoc/
Apache License 2.0
231 stars 30 forks source link

Links in block quotes don't get translated #9

Closed AllenDowney closed 3 years ago

AllenDowney commented 3 years ago

Here's an example from Think Bayes. The Markdown input is

If you were inclined to choose the second option, you are in good company.  The biologist [Stephen J. Gould wrote](https://sci-hub.tw/https://doi.org/10.1080/09332480.1989.10554932) :

> I am particularly fond of this example because I know that the [second] statement is least probable, yet a little [homunculus](https://en.wikipedia.org/wiki/Homunculus_argument) in my head continues to jump up and down, shouting at me, "but she can't just be a bank teller; read the description."

And the asciidoc output is

If you were inclined to choose the second option, you are in good
company. The biologist
https://sci-hub.tw/https://doi.org/10.1080/09332480.1989.10554932[Stephen
J. Gould wrote] :

____
I am particularly fond of this example because I know that the [second] statement is least probable, yet a little [homunculus](https://en.wikipedia.org/wiki/Homunculus_argument) in my head continues to jump up and down, shouting at me, "but she can't just be a bank teller; read the description."
____

So it looks like the first link has been translated and the second passed through.

jph00 commented 3 years ago

Block quotes are treated as raw asciidoc in fastdoc. That's because asciidoc has all kinds of odd quoting rules inside quoted blocks which would complex complex parsing to handle automatically.