fastai / fastec2

AWS EC2 computer management for regular folks
121 stars 19 forks source link

Instructions for shell completions only work for bash #3

Closed algal closed 5 years ago

algal commented 5 years ago

The project README says the following:

To add tab completion for your shell (replace bash with the name of your preferred shell, and .bashrc with your shell's config script):

$ fe2 -- --completion bash > ~/.fe2-completion

But all these invocations generate exactly the same file, a file of bash completions:

fe2 -- --completion bash > ~/.fe2-completion
fe2 -- --completion fish > ~/.fe2-completion
fe2 -- --completion zsh > ~/.fe2-completion
fe2 -- --completion sh > ~/.fe2-completion
fe2 -- --completion csh > ~/.fe2-completion
jph00 commented 5 years ago

That's odd. According to the Fire docs, it should work for fish. I'll add a note this may be broken upstream. https://github.com/google/python-fire/blob/master/docs/using-cli.md#completion-flag