Matching NB and Console MasterBar method signatures

fastai / fastprogress

Simple and flexible progress bar for Jupyter Notebook and console

Apache License 2.0

1.08k stars 105 forks source link

Matching NB and Console MasterBar method signatures #66

Closed danielpcox closed 4 years ago

danielpcox commented 4 years ago

NBMasterBar had keyword args in two of its methods that were not handled in ConsoleMasterBar, which would cause projects using those kwargs to work correctly while in development in the notebook, but fail when run in the console, e.g., in projects using nbdev.

This PR just updates the two signatures for update_graph and show_imgs in ConsoleMasterBar to include **kwargs, and adds a couple of lines to the ConsoleMasterBar test to confirm.

Fixes #65

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

jph00 commented 4 years ago

Many thanks. Sorry for not noticing this PR! Feel free to at-mention or assign me as a reviewer in the future.