fastai / fastprogress

Simple and flexible progress bar for Jupyter Notebook and console

Apache License 2.0

1.09k stars 106 forks source link

Fixes issue #69 Visual Studio Code does not render progress bars corr… #70

Open hsm opened 4 years ago

hsm commented 4 years ago

…ectly

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

jph00 commented 2 years ago

sorry @hsm I only just saw this. it's a good idea, although it means that fastprogress won't work unless ipywidgets is installed. how about only using ipywidgets in the case where the user is on vscode?

BTW, you need to nbdev_install_git_hooks to ensure you have a clean NB in your PR.

guillochon commented 1 year ago

Hi, I hit this bug in VSCode and used the monkeypatch @hsm wrote in this post here to fix it:

from IPython.display import clear_output, DisplayHandle
def update_patch(self, obj):
    clear_output(wait=True)
    self.display(obj)
DisplayHandle.update = update_patch

Any chance some sort of fix can be merged into the main branch? It's been impacting quite a few users I think for over 2 years now.

codewithcheese commented 1 year ago

@guillochon note that progress bars were working in VSCode and only stopped a few days ago. This is an old PR that I guess was fixed in a different way. Here is the new issue https://github.com/fastai/fastprogress/issues/104

Either way your workaround is useful for the current issue, thanks. You may want to post your workaround on the issue, it is closer to the intended output than the suggestions.

codermrrob commented 1 year ago

104#issuecomment-1482350888