fastai / fastprogress

Simple and flexible progress bar for Jupyter Notebook and console
Apache License 2.0
1.08k stars 105 forks source link

Check that stdout exposes `isatty` #81

Closed scw closed 2 years ago

scw commented 3 years ago

In embedded environments and other contexts, the sys.stdout stream may be a custom implementation, and that implementation may not implement isatty. Check for its existence before use. We ran into this in the case of ArcGIS Pro which contains embedded Notebooks and uses fastprogress.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jph00 commented 2 years ago

Many thanks!