fastai / ghapi

A delightful and complete interface to GitHub's amazing API
https://ghapi.fast.ai/
Apache License 2.0
527 stars 57 forks source link

HTTP Error 500: Internal Server Error when calling get_audit_log with "after" variable #101

Open kbroughton opened 2 years ago

kbroughton commented 2 years ago

api.orgs.get_audit_log(ORG, per_page=10, page=2, after="2021-09-27T15:05:06+01:00") // Here I'm using time format as per GHAPI rest docs. ghapi python docs suggest 2021-09-27 should work. Tried // this and also timestamps, but all gave internal error.

If i remove the "after" variable, the call works fine.

I believe the problem is that the "after" variable is in [Link header format](api.orgs.get_audit_log(ORG, per_page=10, page=2, after="2021-09-27T15:05:06+01:00")) and perhaps this doesn't get autogenerated correctly.

Link: https://api.github.com/orgs/ORG/audit-log?after=MTYwMTkxOTU5NjQxM3xZbGI4VE5EZ1dvZTlla09uWjhoZFpR&before=; rel="next",

The value between after= and & does not completely URL + base64 decode to an obvious time format.

Signature:  
api.orgs.get_audit_log(
    org,
    phrase=None,
    include=None,
    after=None,
    before=None,
    order=None,
    per_page=None,
    page=None,
)
Type:        _GhVerb
String form:
orgs.get_audit_log(org, phrase=None, include=None, after=None, before=None, order=None, per_page=None, page=None)
https://docs.github.com/rest/reference/orgs#get-audit-log
File:        /opt/conda/lib/python3.9/site-packages/ghapi/core.py

I would expect any values in the signature to specify the time format required, possibly add an example to the docs, and the error should be something less severe than a 500 internal error.