fastai / ghapi

A delightful and complete interface to GitHub's amazing API
https://ghapi.fast.ai/
Apache License 2.0
609 stars 62 forks source link

Fix links to GitHub docs #136

Closed hwine closed 2 years ago

hwine commented 2 years ago

Apparently, GitHub docs were changed to assume a default doc version of 'free-pro-team@latest', and droped support for specifying that explicitly.

Additionally, remove the '/en' locale specifier, so the browser can negotiate the appropriate one for every user.

Changes were done mechanically using

for f in $(rg '@latest' -l) ; do
    sed --in-place=.doc \
        -e 's:docs.github.com/en/free-pro-team@latest/:docs.github.com/:g' \
        $f
done

N.B. the CONTRIBUTING.md section on documentation changes appears to reference an older procedure. Please let me know if a different procedure should be used now.

Fixes #135

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jph00 commented 2 years ago

Many thanks!