fastai / ghapi

A delightful and complete interface to GitHub's amazing API
https://ghapi.fast.ai/
Apache License 2.0
609 stars 62 forks source link

In version 1.0.0, ghapi.__version__ returns "0.1.23" when it should return "1.0.0" #144

Closed goxberry closed 2 years ago

goxberry commented 2 years ago

Reproducer in a terminal on M1 MacBook Pro, macOS 12.5, Python 3.8.9 (from Xcode Command Line Tools):

python3 -m venv ghapi_venv
./ghapi_venv/bin/pip3 install -U pip setuptools wheel
./ghapi_venv/bin/pip3 install ghapi==1.0.0
./ghapi_venv/bin/python3 -c "import ghapi; print(ghapi.__version__)"

Expected output of last command: 1.0.0

Observed output:

goxberry@comp ~ % python3 -m venv ghapi_venv
goxberry@comp ~ % ./ghapi_venv/bin/pip3 install -U pip setuptools wheel
# ...snip...
Successfully installed pip-22.2.1 setuptools-63.2.0 wheel-0.37.1
goxberry@comp ~ % ./ghapi_venv/bin/pip3 install -U ghapi==1.0.0
# ...snip...
Successfully installed fastcore-1.5.11 ghapi-1.0.0 packaging-21.3 pyparsing-3.0.9
goxberry@comp ~ % ./ghapi_venv/bin/python3 -c "import ghapi; print(ghapi.__version__)"
0.1.23

Other system data:

goxberry@comp ~ % python3 --version
Python 3.8.9
goxberry@comp ~ % uname -a
Darwin comp 21.6.0 Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:22 PDT 2022; root:xnu-8020.140.41~1/RELEASE_ARM64_T6000 arm64

Happy to submit a patch to fix; just let me know if incrementing the version to 1.0.1 would be acceptable.

jph00 commented 2 years ago

Thanks - fixed in latest.