The package published to pypi is versioned 2.3.12, while the latest tag in this repo is 2.3.11.
This makes pre-commit and the nbdev-ci workflow use different versions.
Provide a minimally reproducible example
Using the pre-commit tool with pre-commit-config.yaml:
The lint job succeeds and the test job fails on the initial 00_core.ipynb.
This is because that the nbdev_clean command cleans the initial notebook in 2.3.12 (which is used by the CI as it is published to pypi) while in 2.3.11 (which is the latest tag in this repo) it doesn't clean.
The nbdev-ci git action installs the latest from pypi, while pre-commit installs from github, and so the versions differ.
This is confirmed by installing the specific versions and running nbdev_clean:
pip install nbdev=2.3.12
nbdev_clean
git status
# files will change
pip install nbdev=2.3.11
nbdev_clean
git status
# No files will change
Proposed fixes
I can work around it by specifying the specific hash of version 2.3.12 (which should probably be 744a52d).
An easy fix would be to tag this commit as 2.3.12.
A more permanent solution will be to enable version pining in the ci workflow, I might create a pull request for that in the coming days.
The package published to pypi is versioned
2.3.12
, while the latest tag in this repo is2.3.11
. This makespre-commit
and the nbdev-ci workflow use different versions.Provide a minimally reproducible example
Using the
pre-commit
tool withpre-commit-config.yaml
:and
.github/workflows/test.yaml
:The
lint
job succeeds and thetest
job fails on the initial00_core.ipynb
.This is because that the
nbdev_clean
command cleans the initial notebook in2.3.12
(which is used by the CI as it is published to pypi) while in2.3.11
(which is the latest tag in this repo) it doesn't clean.The nbdev-ci git action installs the latest from pypi, while
pre-commit
installs from github, and so the versions differ.This is confirmed by installing the specific versions and running
nbdev_clean
:Proposed fixes
I can work around it by specifying the specific hash of version
2.3.12
(which should probably be 744a52d).An easy fix would be to tag this commit as
2.3.12
.A more permanent solution will be to enable version pining in the ci workflow, I might create a pull request for that in the coming days.